Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cisagov/setup-env-github-action to provide the Python and Go versions to use #157

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 13, 2023

🗣 Description

This pull request updates the build workflow to use the versions of Python and Go tracked in cisagov/setup-env-github-actions added with cisagov/setup-env-github-action#70.

Note

This pull request should replace #154 if it is approved.

💭 Motivation and context

This change will make it easier to update to new versions of Python and Go when they release. It will also make updates significantly easier and more consistent in downstream repositories that have these values hard-coded in multiple jobs (once this change is propagated).

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.

Note

I plan on rebasing to remove the commit if cisagov/setup-env-github-action#70 is approved and merged.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code labels Nov 13, 2023
@mcdonnnj mcdonnnj self-assigned this Nov 13, 2023
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj force-pushed the improvement/get_more_versions_from_action branch from 699bf63 to 9c92d98 Compare November 13, 2023 21:54
@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Nov 13, 2023
@mcdonnnj mcdonnnj mentioned this pull request Mar 5, 2024
6 tasks
@mcdonnnj mcdonnnj force-pushed the improvement/get_more_versions_from_action branch from 9c92d98 to 7169dcf Compare March 6, 2024 01:14
@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 6, 2024
Merged via the queue into develop with commit 95a61f5 Mar 6, 2024
7 checks passed
@mcdonnnj mcdonnnj deleted the improvement/get_more_versions_from_action branch March 6, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Development

Successfully merging this pull request may close these issues.

3 participants