This repository was archived by the owner on Nov 21, 2024. It is now read-only.
add support for tenant level user to make API calls for mtt aaa #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renukavinay
reviewed
Nov 1, 2024
Collaborator
renukavinay
left a comment
renukavinay
left a comment
There was a problem hiding this comment.
tenant_id is used for logging purpose. Add tenant name using the session
Collaborator
Author
Is there an API to get the tenant name from tenant level, that I can use for this ? |
sbasan
previously approved these changes
Nov 2, 2024
sbasan
suggested changes
Nov 5, 2024
JimOverholt
reviewed
Nov 5, 2024
JimOverholt
reviewed
Nov 5, 2024
JimOverholt
reviewed
Nov 5, 2024
Co-authored-by: JimOverholt <[email protected]>
Co-authored-by: JimOverholt <[email protected]>
Co-authored-by: JimOverholt <[email protected]>
renukavinay
previously approved these changes
Nov 6, 2024
sbasan
previously approved these changes
Nov 6, 2024
renukavinay
previously approved these changes
Nov 6, 2024
Collaborator
renukavinay
left a comment
renukavinay
left a comment
There was a problem hiding this comment.
mock session endpoints could have been added in unittest.
otherwise lgtm
JimOverholt
approved these changes
Nov 6, 2024
bboot2
approved these changes
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
add support for tenant level user to make API calls for mtt aaa.
currently only provider as a tenant user is able to make API calls because there are provider level calls in the existing classes that are forbidden for tenant level users.
Description of changes:
i have added 2 more classes, where we don't invoke provider level APIs.
So tenant level users can add tacacs or radius servers
Checklist: