Filter chain #155
Draft
Filter chain #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynz0r
force-pushed
the
filter_chain
branch
2 times, most recently
from
5f07e9c
to
c25ded8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose the list of network filter names and their configuration that is matched when:
This allows code built in top of the
adspackage to dynamically query and then instantiate the necessary network filters the inbound/outbound traffic should go through.New API endpoint has been introduced:
ListenerProperties.NetworkFilters(...NetworkFilterSelectOption) ([]NetworkFilter, error)ClientProperties.NetworkFilters(...NetworkFilterSelectOption) ([]NetworkFilter, error)The filter chain is matched based on various properties such as destination port, destination IP, filter type etc which can be provided through the
NetworkFilterSelectOptionarguments.Note: in case of
ClientProperties.NetworkFiltersthe destination port and IP is added automatically to the matching criteria as that information is available in theClientPropertiesstruct.Type of Change