Skip to content

Improve collect error messages #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

Improve collect error messages #4

merged 1 commit into from
Aug 22, 2025

Conversation

@simonchatts
Copy link
Contributor

@simonchatts simonchatts commented Jul 6, 2025

Description

There are a couple of likely reasons the collect script fails:

  • not running as root
  • not having perf in the PATH

Hitting one or both of these would likely define a user's first experience with the tool. So this PR provides better error messages.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@simonchatts simonchatts merged commit f387291 into cisco-open:main Aug 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmizutani jimmizutani jimmizutani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonchatts @jimmizutani