Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript import #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add typescript import #98

wants to merge 2 commits into from

Conversation

adrianj98
Copy link
Collaborator

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • [ x] New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adrianj98 adrianj98 requested a review from a team as a code owner January 15, 2025 00:12
allow the import of ts where ts is allowed.
d19a3be 
test: imports ts on bun and test catch error in npm

feat(TemplateProcessor): add support for importing TypeScript files

fix(TemplateProcessor): handle TypeScript imports with error handling

test(TemplateProcessor): add tests for importing JavaScript and TypeScript files

Add support for importing TypeScript files in environments that support it,
and provide error handling for environments that do not. Add tests to
verify the functionality of importing both JavaScript and TypeScript files.
@adrianj98 adrianj98 force-pushed the add-typescript-import branch from 6b2a4da to d19a3be Compare January 15, 2025 00:21
geoffhendrey
geoffhendrey requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@geoffhendrey geoffhendrey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • be sure to tp.close() in a finally block for each test
  • bump version in package.json to 0.1.51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffhendrey geoffhendrey geoffhendrey requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianj98 @geoffhendrey