improve foreign interface signed and unsigned integer conversion #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaddell
force-pushed
the
owaddell/foreign2
branch
from
4a5de4f
to
5eacbc8
Compare
burgerrg
approved these changes
Oct 5, 2023
This commit adds types such as Sint32_t and Suint64_t that downstream code can use reliably with foreign integer conversion entry points such as Sinteger32 and Sunsigned64. CSUG now documents these functions using the new types instead of "<32-bit int type>", "<64-bit unsigned type>", etc.
owaddell
force-pushed
the
owaddell/foreign2
branch
from
5eacbc8
to
629afef
Compare
|
Thanks for the quick review, Bob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
Sinteger32andSinteger64Stry_integer_value(and 32- and 64-bit variants) that is likeSinteger_valuebut returns a boolean to indicate success or failure instead of invokinglongjmpviaS_error1