improve makefile cooperation with zuofiles #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `+` more consistently to ensure that jobserver flags are passed along to `zuo`. Also, use an upgraded Zuo so that `make` flags like `-n`/`--print-only` are propagated to Zuo and recognized to avoid actually building --- except that `zuo` itself is built even by `make -n`. Some zuofile changes here take advantage of Zuo support for dry-run modes like `-n`, but it's a very limited effort. Reporting of would-be build steps remains shallow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to avoid surprise from
make -nperforming a build instead of just printing build steps. (The reason thatmake -ncurrently tends to build is subtle: the recipe steps mention$MAKE, and that causes GNU Make to treat the step as if starts with+.)The change uses
+explicitly and consistently to ensure that jobserver flags are passed along tozuo. Also, the commit uses an upgraded Zuo so thatmakeflags like-n/--print-onlyare propagated to Zuo and recognized to avoid actually building --- except thatzuoitself is built even bymake -n.Some zuofile changes here take advantage of Zuo support for dry-run modes like
-n, but it's a very limited effort. Reporting of would-be build steps remains shallow.