restore simpler Windows CI #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerrg
reviewed
Oct 23, 2023
.github/workflows/build.sh
Outdated
| @@ -2,8 +2,7 @@ | |||
| set -e -o pipefail | |||
| export ZUO_JOBS="$(getconf _NPROCESSORS_ONLN)" | |||
| if test "$TOOLCHAIN" = vs ; then | |||
| # cmd.exe /c "build.bat $TARGET_MACHINE" | |||
| echo assuming built previously | |||
| cmd.exe //c "build.bat $TARGET_MACHINE" | |||
There was a problem hiding this comment.
Try MSYS_NO_PATHCONV=1 cmd.exe /c build.bat $TARGET_MACHINE
There was a problem hiding this comment.
Thanks — I see how that can be better. Change pushed.
Mostly reverts 01b5bb6, but also adds `MSYS_NO_PATHCONV=1` to solve the original problem, which is that Windows `bash` may treat arguments that start with `/` specially unless `MSYS_NO_PATHCONV` is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly reverts 01b5bb6, but also
changes "/c" to "//c"usesMSYS_NO_PATHCONV=1--- which seems to be the right repair to the original problem based on the way Windowsbashvariants treat arguments that start with/.