ensure short callbacks get around to a garbage collection #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If foreign code invaokes a short callback while also allocating (e.g., because it's invoking the callback in a new thread), then memory could increase indefinitely without a garbage collection triggered. Avoid that situation by making sure that a callback includes a trap check. Also, detect on thread creation whether a collection is pending, and setting the thread's trap value to minimum in that case. Meanwhile, "foreign4.c" as part of the test suite wasn't checking threading as intended on some platforms (such as macOS), and that's fixed in this commit.
burgerrg
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102.
If foreign code invokes a short callback while also allocating (e.g., because it's invoking the callback in a new thread), then memory could increase indefinitely without a garbage collection triggered. Avoid that situation by making sure that a callback includes a trap check. Also, detect on thread creation whether a collection is pending, and setting the thread's trap value to minimum in that case.
Meanwhile, "foreign4.c" as part of the test suite wasn't checking threading as intended on some platforms (such as macOS), and that's fixed in this commit.