improve some tests that have been unreliable #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `compute-size-increments` test has been a long-time problem. It turns out that it was failing randomly due to a random list of symbols stashed in a thread parameter by an earlier test; sometimes, one of those symbols can reach a lot of data. The solution here is to not count data reachable from thread parameters. A `cost-center-time` test has been failing on very slow machines. As a timing test, it's inherently unreliable, but turning up the limit should make failures rare enough without making the test useless.
burgerrg
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
compute-size-incrementstest has been a long-time problem. It turns out that it was failing randomly due to a random list of symbols stashed in a thread parameter by an earlier test; sometimes, one of those symbols can reach a lot of data. The solution here is to not count data reachable from thread parameters.A
cost-center-timetest has been failing on very slow machines. As a timing test, it's inherently unreliable, but turning up the limit should make failures rare enough without making the test useless.