Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos and reformat code #768

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Correct typos and reformat code #768

merged 2 commits into from
Dec 7, 2023

Conversation

maoif
Copy link
Contributor

@maoif maoif commented Nov 23, 2023

Corrected some typos,
Changed many tabs to 4-whitespaces,
Reformatted some backend code.

Some changes might be unnecessary. Take them as you see fit.

maoif and others added 2 commits November 28, 2023 09:16
Changed many tabs to 4-whitespaces.
Reformatted some backend code.
@mflatt
Copy link
Contributor

mflatt commented Nov 28, 2023

Overall, I'm ok with reformatting to remove tabs, but it does complicate tools like git blame, so I would normally leave it alone. Let's see what others think.

There were a few places where tabs has been replaced by 4 spaces but needed 8, so I pushed a small revision here.

@samth
Copy link
Contributor

samth commented Nov 28, 2023

You can use -w with git blame to ignore whitespace changes. It's also possible to create a repository-level config file that notes particular revisions to ignore for the purposes of git blame.

@mflatt mflatt merged commit 991978d into cisco:main Dec 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants