Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer more reads from a boot-file file descriptor #769

Merged
merged 1 commit into from
Nov 30, 2023
Merged

buffer more reads from a boot-file file descriptor #769

merged 1 commit into from
Nov 30, 2023

Commits on Nov 28, 2023

  1. buffer more reads from a boot-file file descriptor 

    Without this additional buffering, loading boot files can trigger
thousands of small reads to parse a boot file. Introducing buffering
earlier in the process to reduce the number of those `read` system
calls to between 100 and 200.

The difference in startup time turns out to be very small on Linux and
macOS --- just a a couple of milliseconds, if anything. But buffering
is generally a good idea, and the change makes a startup system-call
trace look less suspicious.

In addition to buffering changes, this commit adds
`Sregister_boot_file_bytes`, so that an embedding application can
point to bytes that are already loaded into memory.
    @mflatt
    mflatt committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    90d612d View commit details
    Browse the repository at this point in the history