remove time-t-bits from machine definition #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to pick `time-t-bits` is a problem, particularly for i3le, since some 32-bit Linux variants now use a 64-bit `time_t`. Fortunately, the only use of `time-t-bits` is in the kernel to select between `Sinteger64` and `Sinteger32`, and just using `Sinteger64` is safe.
burgerrg
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to pick
time-t-bitsis a problem, particularly for i3le, since some 32-bit Linux variants now use a 64-bittime_t. Fortunately, the only use oftime-t-bitsis in the kernel to select betweenSinteger64andSinteger32, and just usingSinteger64is safe.