repair pseudo-random-generator-next! for large integers
#831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mflatt
force-pushed
the
randint
branch
2 times, most recently
from
11a45de
to
482fda0
Compare
burgerrg
reviewed
Apr 30, 2024
For an argument exact integer greater than 4294967087, generation of a random integer by piecing together smaller random numbers was broken. It didn't cover the whole range uniformly, and by mistreating the largest part of the integer, it could always produce 0 (e.g., for `(expt 2 32)`). Closes cisco#830
burgerrg
approved these changes
Apr 30, 2024
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an argument exact integer greater than 4294967087, generation of a random integer by piecing together smaller random numbers was broken. It didn't cover the whole range uniformly, and by mistreating the largest part of the integer, it could always produce 0 (e.g., for
(expt 2 32)).Closes #830