Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix parameter v should be case insensitive #841

Closed
wants to merge 2 commits into from

Conversation

olopierpa
Copy link
Contributor

No description provided.

@jltaylor-us
Copy link
Contributor

Nice find; simple fix... I like it! Probably worth adding a test - just duplicating one of the few tests of ~v in mats/format.ms should be sufficient, I'd think. And an entry in the release notes...

Unfortunately, I think release_notes.stex has not yet been updated for capturing changes since the 10.0.0 release. That's on us, since I assume that at least some of the bug fixes that @mflatt has committed since the 10.0.0 release are Release Note worthy (and I watched them all go in without thinking about it, either). We'll get back to you on that.

@olopierpa
Copy link
Contributor Author

Thanks. Added the tests in a different merge request. Sorry I don't know how to merge the 2 requests.

@olopierpa olopierpa closed this Jun 17, 2024
@olopierpa
Copy link
Contributor Author

Trying again shortly

@olopierpa olopierpa deleted the patch-1 branch June 17, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants