improve support for lists in cptypes #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an old commit by @gus-massa that I missed when merging Racket changes toward version 10. I discovered the missing commit when double-checking for differences between Racket's current copy of Chez Scheme and this repo. I think maybe I was concerned at the time with issue discussed in racket/racket#4610, and meant to set it aside temporarily when merging. But as the discussion there says, this commit doesn't introduce the issue, and I believe it's an improvement on its own. |
burgerrg
reviewed
Aug 6, 2024
s/cptypes-lattice.ss
Outdated
| @@ -285,9 +288,13 @@ | |||
| (define flvector*-mask #b0100000000000000) | |||
| (define box-mask #b1000000000000000) | |||
|
|
|||
| ;These two are more tricky, becuase they are not a constant property. | |||
There was a problem hiding this comment.
These two are trickier, because they are not constant properties.
Move `list` form the normalptr slot to the multiplet slot.
In particular, this allows the reduction of
(lambda (x f)
(unless (list-assuming-immutable? x)
(f)
(list-assuming-immutable? x)))
`pair`s are split in `list-pairs` and `nonlist-pairs`.
A `pair` may go from one classification to the other,
so the internal representations of the `list?` predicate
use both of them or neither.
burgerrg
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
listform the normalptr slot to the multiplet slot. In particular, this allows the reduction ofpairs are split inlist-pairsandnonlist-pairs. Apairmay go from one classification to the other, so the internal representations of thelist?predicate use both of them or neither.