Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect wrapping in quote-syntax #867

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Conversation

mnieper
Copy link
Contributor

@mnieper mnieper commented Aug 26, 2024

This fixes issue #861.

The mistake was an incorrect application of a wrap.

@burgerrg
Copy link
Contributor

Thank you for finding and fixing this bug! Please add a subsection to the release notes under section:bugfixes for this.

@burgerrg
Copy link
Contributor

Did you intend to update the zlib & zuo submodules? I'd prefer to see those kinds of updates in separate pull requests.

@mnieper
Copy link
Contributor Author

mnieper commented Aug 26, 2024

Did you intend to update the zlib & zuo submodules?

I didn't. Thanks for catching this.

@mnieper
Copy link
Contributor Author

mnieper commented Aug 26, 2024

Thank you for finding and fixing this bug! Please add a subsection to the release notes under section:bugfixes for this.

I missed that. There is now a subsection about the bug in my patch.

@burgerrg
Copy link
Contributor

The fix to the submodule update didn't resolve it, so I took the liberty of rewriting history on your branch to eliminate the submodule updates in the first place.

@mflatt
Copy link
Contributor

mflatt commented Sep 24, 2024

When I add just the test here, unpatched Chez Scheme still passes. Maybe I'm confused, but I think it's because the bug is related to annotations, and .ms files are loaded in that way that doesn't get them. If that's right, here's a test that explicitly constructs annotations and fails for me before and passes after.


   (let ([src (make-source-object
               (make-source-file-descriptor "src" (open-bytevector-input-port '#vu8()))
               1
               2)])
     (identifier?
      (eval
       (make-annotation `(quote-syntax
                          ,(make-annotation
                            'if
                            src
                            'if))
                        src
                        '(quote-syntax if)))))

@mflatt mflatt merged commit 613e127 into cisco:main Sep 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants