Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for gcm_x_8 #683

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

pabuhler
Copy link
Member

RFC 7714 only defines 16 byte tags for GCM.

This removes the config options to use 8 byte, it is still possible to do it but it should not be so easy as a predefined policy.

RFC 7714 only defines 16 byte tags for GCM.
Copy link
Contributor

@paulej paulej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but do you think there might be people using the shorter tags? While it's not in the final spec, it was in the drafts for a while.

@pabuhler
Copy link
Member Author

Changes look fine, but do you think there might be people using the shorter tags? While it's not in the final spec, it was in the drafts for a while.

they might be but maybe this is what they need to wake to the fact that it is not standard ...

@pabuhler pabuhler merged commit 24da558 into cisco:main Jan 15, 2024
33 checks passed
@pabuhler pabuhler deleted the remove-gcm-8-byte-tag branch January 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants