Renamed srtp_octet_string_is_eq, equal is true #685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
srtp_octet_string_is_eq()
tosrtp_octet_string_equal()
and switches the logic of the return value. That function returnedfalse
if equal, which was opposite of what the name suggests.However, every test is actually looking for inequality. As such, perhaps a better name might be
srtp_octet_string_unequal()
or something? I don't care what we name this, but I'd prefer for the name reflect what it's doing.