Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed srtp_octet_string_is_eq, equal is true #685

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

paulej
Copy link
Contributor

@paulej paulej commented Jan 15, 2024

This PR renames srtp_octet_string_is_eq() to srtp_octet_string_equal() and switches the logic of the return value. That function returned false if equal, which was opposite of what the name suggests.

However, every test is actually looking for inequality. As such, perhaps a better name might be srtp_octet_string_unequal() or something? I don't care what we name this, but I'd prefer for the name reflect what it's doing.

@paulej paulej requested a review from pabuhler January 16, 2024 19:18
@pabuhler pabuhler merged commit 1396c2a into cisco:main Jan 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants