Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] fix endianness issue while updating srtp keys #711

Merged
merged 3 commits into from
May 3, 2024
Merged

[code] fix endianness issue while updating srtp keys #711

merged 3 commits into from
May 3, 2024

Conversation

pbodilis
Copy link
Contributor

@pbodilis pbodilis commented May 2, 2024

This is bound to the issue described here:

#710

@pbodilis pbodilis mentioned this pull request May 2, 2024
Open
pabuhler
pabuhler approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@pabuhler pabuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

srtp_stream_remove is also wrong in stream_update function, if you like you can change that as well or else I will do it after. Will look to add a unit test to catch this, since it is oblivious missing.

@pbodilis
Copy link
Contributor Author

pbodilis commented May 3, 2024

Done

@pabuhler pabuhler merged commit 0c002e7 into cisco:main May 3, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabuhler pabuhler pabuhler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbodilis @pabuhler