Refactored Docker Images To Use The Elasticseatch Docker Image As Their Base #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as part of attempting to solve #422 (but not doing so because of the issue with MindMeld downloading an x86 build of Duckling from a bucket, I refactored the current Docker containers to instead of being based on a standard Ubuntu image to be based from the official Elasticsearch Docker image. This provides the benefit of instead of having to manually download Elasticsearch into the MindMeld container, it's already there, allowing for faster builds. In addition, it also allows for easy bumping of the Elasticsearch version in 1 place with minimal overhead so issues like the version update being discussed in #386 can easily be taken care of from a Docker perspective.
Also saw @vrdn-23 and @tmehlinger's comments in #386 mentioning looking into this container so decided to make a PR with what I had.
Like I said, did this trying to solve #422 and it not working out but figured might as well contribute the refactor and see if it was something y'all were interested in.
To test, run
docker compose up --build
in thedocker_containers/mindmeld_dep_docker
anddocker_containers/mindmeld_docker
directories.