Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Docker Images To Use The Elasticseatch Docker Image As Their Base #425

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zozman
Copy link
Contributor

@Zozman Zozman commented Jul 6, 2022

So as part of attempting to solve #422 (but not doing so because of the issue with MindMeld downloading an x86 build of Duckling from a bucket, I refactored the current Docker containers to instead of being based on a standard Ubuntu image to be based from the official Elasticsearch Docker image. This provides the benefit of instead of having to manually download Elasticsearch into the MindMeld container, it's already there, allowing for faster builds. In addition, it also allows for easy bumping of the Elasticsearch version in 1 place with minimal overhead so issues like the version update being discussed in #386 can easily be taken care of from a Docker perspective.

Also saw @vrdn-23 and @tmehlinger's comments in #386 mentioning looking into this container so decided to make a PR with what I had.

Like I said, did this trying to solve #422 and it not working out but figured might as well contribute the refactor and see if it was something y'all were interested in.

To test, run docker compose up --build in the docker_containers/mindmeld_dep_docker and docker_containers/mindmeld_docker directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant