Fix Windows hang in testing (#417)

* Move bytes library to Catch2

* Convert tls_syntax to Catch2

* Convert hpke to Catch2

* Convert mls_vectors to Catch2

* Convert main test directory to Catch2

* Make remaining vcpkg changes

* Re-enable unit tests on Windows

* Align vcpkg files on the same baseline

* Upgrade to Catch2 version 3

* Re-enable sanitizers to see if they fix Windows hangs

* Revert changes to CI

* Re-enable tests and disable message protection test

* Disable tree hashes test

* Turn off more tests

* Turn off yet more tests

* Turn off still more tests

* Turn off one more test

* Add tmate debugging

* Run tmate on Windows

* Re-enable tests

* Update CI workflow

* Profile down and instrument test vector test

* Remove verify lines

* More printf debugging!

* Destructure return

* Minimize more

* Go ahead and build/run in the runner

* Quote arguments?

* Simplify return value

* Remove all the logic

* Silence error

* Invoke var::visit

* Really remove *all* the logic

* Silence compiler error

* Everything but the var::visit

* Merely define the variant function

* Add __declspec work-around

* Shift to dummy member work-around

* Take the brakes off

* Take the brakes all the way off

* Turn tmate back on

* Take the brakes all the way off

* Expand comment on work-around

* Re-enable Windows unit tests

Author: bifurcation

.github/workflows/main_ci.yml

@@ -63,16 +63,10 @@ jobs:
       run: |
         cmake --build "${{ env.BUILD_DIR }}" --target test
 
-## XXX(RLB): Unit tests are currently disabled on Windows because of two
-## conflicting bugs.  On the one hand, doctest has a bug that causes
-## doctest_discover_tests to fail when tests are built with sanitizers.  On the
-## other hand, if tests are not built with sanitizers, then the unit tests hang
-## in the middle of the test run.
-##
-##    - name: Unit Test (Windows)
-##      if: matrix.os == 'windows-latest'
-##      run: |
-##        cmake --build "${{ env.BUILD_DIR }}" --target RUN_TESTS
+    - name: Unit Test (Windows)
+      if: matrix.os == 'windows-latest'
+      run: |
+        cmake --build "${{ env.BUILD_DIR }}" --target RUN_TESTS
 
   interop-test:
     if: github.event.pull_request.draft == false

include/mls/common.h

@@ -83,6 +83,14 @@ template<class... Ts>
 struct overloaded : Ts...
 {
   using Ts::operator()...;
+
+  // XXX(RLB) MSVC has a bug where it incorrectly computes the size of this
+  // type.  Microsoft claims they have fixed it in the latest MSVC, and GitHub
+  // claims they are running a version with the fix.  But in practice, we still
+  // hit it.  Including this dummy variable is a work-around.
+  //
+  // https://developercommunity.visualstudio.com/t/runtime-stack-corruption-using-stdvisit/346200
+  int dummy = 0;
 };
 
 // clang-format off