Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserInfo VC details #360

Merged
merged 15 commits into from
Sep 5, 2023
Merged

UserInfo VC details #360

merged 15 commits into from
Sep 5, 2023

Conversation

bifurcation
Copy link
Contributor

@bifurcation bifurcation commented Aug 29, 2023 •
edited
Loading

This PR adds more capabilities for UserInfo VC credentials:

  • Parsing to extract the salient attributes, including the subject public key
  • ... and thus a real implementation of UserInfoVCCredential::valid_for
  • Validation of the signature on a UserInfo VC given an issuer's public key

Marking as draft right now because:

  • Add tests for VC parsing / validation
  • Rebase on current main
  • Address review comments

glhewett
glhewett approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@glhewett glhewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some thoughts. Most of which probably don't require a response. Other than the fact that I am trying to learn your style.

lib/hpke/src/signature.cpp Show resolved Hide resolved
lib/hpke/src/signature.cpp Show resolved Hide resolved
lib/hpke/src/userinfo_vc.cpp Show resolved Hide resolved
lib/hpke/src/userinfo_vc.cpp Show resolved Hide resolved
lib/hpke/src/userinfo_vc.cpp Outdated Show resolved Hide resolved
lib/hpke/src/userinfo_vc.cpp Outdated Show resolved Hide resolved
@bifurcation bifurcation marked this pull request as ready for review August 31, 2023 22:06
@glhewett glhewett self-requested a review September 1, 2023 03:39
glhewett
glhewett approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@glhewett glhewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You might want to squash the branch. That is just my preference.

@bifurcation bifurcation merged commit 949c447 into main Sep 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhasHere suhasHere suhasHere approved these changes

@glhewett glhewett glhewett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bifurcation @glhewett @suhasHere