Add brainpoolP256r1 curve support #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alparodev
approved these changes
Jul 31, 2023
aaccenture
reviewed
Aug 2, 2023
lib/algorithms/helpers.js
Outdated
| } | ||
|
|
||
| try { | ||
| promise = Promise.resolve(nodejs.apply(null, args)); | ||
| promise = promise.catch(check); |
There was a problem hiding this comment.
nodejs.apply(null, args) is a synchronous operation so i think this statement is unreachable.
There was a problem hiding this comment.
@aaccenture good point! nodejs.apply is a synchronous function that can throw. However, it also returns a promise that can reject. Hence we need to both wrap the call in a try/catch, and call promise.catch here. I'll add a comment to clarify.
There was a problem hiding this comment.
Thanks for the link, I saw return Promise.reject() so this catch here save us from unhandled promise rejection. Legitimate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brainpoolP256r1 curve is defined in RFC 5639, and is a recommended standard (PDF) by the German Ministry for Information Security. This curve is used in several of the German healthcare system's digitization standards (PDF; and also in German, sorry) for authenticating with various specialist services.