Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pSpatialLayer variable in DetermineTemporalSettings #3761

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

fippo
Copy link
Contributor

@fippo fippo commented Jun 8, 2024

which breaks on Mac CI settings due to the variable being unused

Fixes the build issue from #3752, as a separate commit for papertrail reasons.

./codec/encoder/core/inc/param_svc.h:496:26: error: variable 'pSpatialLayer' set but 
not used [-Werror,-Wunused-but-set-variable]
    SSpatialLayerConfig* pSpatialLayer = &sSpatialLayers[0];

which break on Mac CI settings due to the variables being unused
@fippo
Copy link
Contributor Author

fippo commented Jun 12, 2024

looks like the Mac defaults changed? WDYT about adding

  '-Werror',
  '-Wunused-but-set-variable',

to supported_arguments in the meson file?

@BenzhengZhang
Copy link
Collaborator

mac build failed, test/decoder/DecUT_DecExt.cpp:143:11: error: variable 'iSliceIndex' set but not used [-Werror,-Wunused-but-set-variable] @fippo

@fippo
Copy link
Contributor Author

fippo commented Jun 21, 2024

Thank you, there was more after that even (and oddly adding those compiler defines to the linux build did not help).
I did a "fork" of the repo to get the CI jobs running and now https://github.com/fippo/openh264-mac-build/actions/runs/9614665797 passes for me

@BenzhengZhang BenzhengZhang merged commit de02617 into cisco:master Jul 1, 2024
8 checks passed
@fippo fippo deleted the fix-build branch July 1, 2024 14:39
bgilbert added a commit to bgilbert/openh264 that referenced this pull request Nov 10, 2024
Avoids Meson warning at configure time:

    meson.build:49: WARNING: Consider using the built-in werror option instead of using "-Werror".

Fixes: de02617 ("Remove unused pSpatialLayer variable in DetermineTemporalSettings (cisco#3761)")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants