Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken decode result in multi-thread decoding. #3782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tyan0
Copy link
Contributor

@tyan0 tyan0 commented Aug 30, 2024

If the following test video is decoded with multi-thread by openh264, the decode result will be broken.

testcase7.mp4

The following file is the re-encoded result of the broken decoded result.

testcase7-broken.mp4

This patch just removes

          if (iThreadCount > 1) isNewFrame = false;

which was introduced by the commit 54f6c4d, but it is not clear why this was necessary.

@joakim-tjernlund
Copy link

Finding out why that line was added may be hard.
Just merge to master and see if any issues are reported ?

@joakim-tjernlund
Copy link

FYI, I have added this patch to our openh264(on top of master) and not seen/heard any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants