Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether given amount is feasible to spend or not. #265

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

KnowWhoami
Copy link
Collaborator

@KnowWhoami KnowWhoami commented Sep 13, 2024

Aims to solve 2nd Task of #264

@KnowWhoami KnowWhoami requested a review from mojoX911 September 13, 2024 10:26
@KnowWhoami KnowWhoami marked this pull request as draft September 17, 2024 13:27
@mojoX911
Copy link

Ack. Looks good. LMK when its ready for review.

@KnowWhoami KnowWhoami marked this pull request as ready for review September 19, 2024 13:13
@KnowWhoami KnowWhoami marked this pull request as draft September 21, 2024 09:25
@KnowWhoami KnowWhoami removed the request for review from mojoX911 September 26, 2024 14:07
@KnowWhoami KnowWhoami self-assigned this Sep 26, 2024
@KnowWhoami KnowWhoami requested a review from mojoX911 September 26, 2024 14:09
@KnowWhoami KnowWhoami marked this pull request as ready for review September 26, 2024 14:09
@KnowWhoami
Copy link
Collaborator Author

I have added one more test in the force push changes.
There are some quick TODOs -> on which I need suggestions.

@KnowWhoami KnowWhoami force-pushed the spend_from_wallet branch 2 times, most recently from 335f8e7 to edaaa6c Compare September 27, 2024 10:19
Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Few comments.

src/wallet/direct_send.rs Outdated Show resolved Hide resolved
src/wallet/direct_send.rs Outdated Show resolved Hide resolved
src/wallet/direct_send.rs Outdated Show resolved Hide resolved
src/wallet/direct_send.rs Outdated Show resolved Hide resolved
src/wallet/direct_send.rs Show resolved Hide resolved
@mojoX911
Copy link

Sorry its not an approve, but changes requested in the review.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (ac7a351) to head (54b9299).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
src/wallet/direct_send.rs 54.16% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   80.54%   78.33%   -2.21%     
==========================================
  Files          26       30       +4     
  Lines        6230     6297      +67     
==========================================
- Hits         5018     4933      -85     
- Misses       1212     1364     +152     
Flag Coverage Δ
78.33% <54.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojoX911 mojoX911 mentioned this pull request Oct 3, 2024
10 tasks
Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 381e15a

@mojoX911 mojoX911 merged commit b7f7dc3 into citadel-tech:master Oct 5, 2024
12 checks passed
@KnowWhoami KnowWhoami deleted the spend_from_wallet branch October 7, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants