-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check whether given amount is feasible to spend or not. #265
Conversation
dde76d5
to
7b90d5b
Compare
Ack. Looks good. LMK when its ready for review. |
7b90d5b
to
e35fb64
Compare
I have added one more test in the force push changes. |
335f8e7
to
edaaa6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Few comments.
Sorry its not an approve, but |
edaaa6c
to
54b9299
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 80.54% 78.33% -2.21%
==========================================
Files 26 30 +4
Lines 6230 6297 +67
==========================================
- Hits 5018 4933 -85
- Misses 1212 1364 +152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 381e15a
Aims to solve 2nd Task of #264