Skip to content

Commit

Permalink
Add verb form of "hearing" term for "testimony of"
Browse files Browse the repository at this point in the history 
@adam3smith What do you think of this?

"hearing" is an item type term rather than a role term, but it makes sense to me to use the verb form of the term to refer to the author/giver of testimony at the hearing

This would be used for localizing phrasing like `(testimony of <author>)`
  • Loading branch information
@bwiernik
bwiernik committed Sep 20, 2023
1 parent 8bbac89 commit 6192d03
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions locales-en-US.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@
<term name="review-book" form="short">bk. rev.</term>
<term name="song" form="short">audio rec.</term>

<!-- VERB ITEM TYPE FORMS -->
<!-- Only where applicable -->
<term name="hearing" form="verb">testimony of</term>

<!-- HISTORICAL ERA TERMS -->
<term name="ad">AD</term>
<term name="bc">BC</term>
Expand Down

5 comments on commit 6192d03

@adam3smith
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not -- is there any reason to think processors would freak out about this? I assume you've tested in Zotero/citeproc-js?

@bwiernik
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it works fine with citeproc-js, and the spec doesn't say anything about what forms different types of terms can have -- all forms are valid for everything as far as the spec is concerned. I'll add this.

Sorry on pushing directly to master, that was a mistake on my part.

@denismaier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No general objections, but what about using the term for testimony together with the term of?

@bwiernik
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t currently have a testimony term

@denismaier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t currently have a testimony term

Oh yeah, sure. I've meant hearing together with of. But I understand that would result in different (inappropriate) terminology.

Please sign in to comment.