Add locales-bal-PK.xml (Balochi – Pakistan) #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwiernik
requested changes
Mar 24, 2024
|
@adam3smith I think we need to update our filename checking regex here. Balochi does not have a 2-letter ISO code, only a 3-letter code, so the filename check is currently failing. |
|
Changing the Regex is simple of course, but I'd like to make sure three-letter language codes won't confuse processors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a locale for Balochi (Pakistan). Some additional change may be necessary to accommodate the three letter language code.
Checklist
<translator>in the<info>block at the beginning of the file.