Merge Fix crash when opening a clip on 3258+ (mr-585)

a6e3f6d - fix(five/editor): fix crash when opening a clip on 3258+
citizenfx · Nov 1, 2024 · a0a8b06 · a0a8b06
2 parents 94e3b9d + a6e3f6d
commit a0a8b06
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/code/components/gta-streaming-five/src/PatchReplayLimits.cpp b/code/components/gta-streaming-five/src/PatchReplayLimits.cpp
@@ -89,16 +89,16 @@ static void* InitializeIPLBuffer()
 	return result;
 }
 
-static constexpr uint32_t NewBufferSize = 1024;
-static uint32_t NewIPLBuffer[NewBufferSize];
-
 static HookFunction hookFunction([]()
 {
 	// CPacketIPL seems to be deprecated and CPacketIPL2 was added instead
 	if (xbr::IsGameBuildOrGreater<3258>())
 	{
+		static const constexpr uint32_t NewBufferSize = 1024;
+		static uint32_t* NewIPLBuffer = (uint32_t*)hook::AllocateStubMemory((size_t)NewBufferSize);
+
 		// Relocate CPacketIPL2 buffer references; stubs from 3258
-		RelocateRelative((void*)&NewIPLBuffer, {
+		RelocateRelative((void*)NewIPLBuffer, {
 			{ "48 8D 15 ? ? ? ? 48 8D 4C 24 ? 48 89 5C 24 ? 89 5C 24 ? E8 ? ? ? ? 48 8D 54 24", 3 },
 			{ "48 8D 0D ? ? ? ? 49 C1 E0 ? E8 ? ? ? ? 89 1D", 3 }
 		});