tweak(citizen-scripting-v8): increase heap size per isolate to match physical memory size #2377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Due to the increasing amount of users using the JS runtime, some users are starting to hit the heap size limit and crashing, this increases the heap limit to match system memory, copying behavior from the mono project for sgen.
It should be notes that this caps at 4GB for some reason, I don't currently have time debug this but its likely a Node limitation.
How is this PR achieving the goal
Setting the isolate heap size to the physical memory size
This PR applies to the following area(s)
SCRT: JS
Successfully tested on
Game builds: Tested, changes aren't build specific.
Platforms: Windows, needs testing on Linux.
Checklist
Fixes issues
Supersedes #1796