-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine net time sync code for OneSync #2381
Refine net time sync code for OneSync #2381
Conversation
Besides a few small nitpicks to make myself feel better, I won't look too hard on this as its mostly moving code around. Does our style guideline include rules on names/ordering/grouping of includes? How netTimeSync is currently structured is a bit unappealing to the eye. |
One benefit here is that as we start refining/decoupling things - we'll figure out a nice convention that allows us to structure functionality a bit better (e.g., gamecode structure vs. hooking vs. onesync protocols, etc). |
2d66539
to
5d710f7
Compare
The goal of this commit is to improve the readability of `rage::netTimeSync` related code. Additionally, it aims to improve the maintainability of `CloneExperiments.cpp` by logically splitting certain parts of the file into appropriate chunks. The code refine isn't intended to be a full fledged refactor but rather a first step towards facilitating future refactoring efforts.
5d710f7
to
751a76c
Compare
Goal of this PR
The goal of this PR is to improve the readability of
rage::netTimeSync
related code. Additionally, it aims to improve the maintainability ofCloneExperiments.cpp
by logically splitting certain parts of the file into appropriate chunks. The code refine isn't intended to be a full fledged refactor but rather a first step towards facilitating future refactoring efforts.I invite everyone to participate in reviewing and suggesting improvements. Please remember that on the current stage I'm not planning to make it more complex than it is right now (i.e. adding abstraction layers, reworking the inner or depended code, etc).
How is this PR achieving the goal
By moving the related code from
CloneExperiments.cpp
to separate.cpp
and.h
files, and making some minor tweaks.This PR applies to the following area(s)
FiveM, RedM
Successfully tested on
Game builds:
FiveM: 1604, 2060, 2189, 2372. 2545, 2612, 2699, 2802, 2944, 3095
RedM: 1311, 1355, 1436, 1491
Platforms: Windows
Checklist
Fixes issues
-