fix(client): Cleanup various static sig patterns and put them in Hook… #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
triage
osmium-cfx
force-pushed
the
hookfunction_sigs_cleanup
branch
from
d78368f to
7c308d8
Compare
…Function's We had a few rare cases here where sigs would be resolved on-demand. There is some small overhead from checking each local static variable, but really this was done so that all the sigs are done before going in-game.
osmium-cfx
force-pushed
the
hookfunction_sigs_cleanup
branch
from
7c308d8 to
3662878
Compare
gottfriedleibniz
approved these changes
Mar 14, 2024
gottfriedleibniz
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Function's.
We had a few rare cases here where sigs would be resolved on-demand.
There is some small overhead from checking each local static variable, but really this was done so that all the sigs are done before going in-game.
Goal of this PR
Put Most if not all sigs into HookFunctions or function stubs that run at startup.
This means that sigs are ran less conditionally(without needing an option) and at startup time instead of 1st time called.
How is this PR achieving the goal
By changing some rare cases of sigs not doing this.
This PR applies to the following area(s)
Client
Successfully tested on
Did basic testing without hints file and it seemed OK
Game builds: Several
Platforms: Windows
Checklist