Workaround for ped props limit in FiveM #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
triage
|
Closes #1486 |
The game has a "soft limit" for the number of available ped props per anchor per model. This patch is intended to fix this limit.
Disquse
force-pushed
the
fivem/ped-prop-limit-fix
branch
from
509b3d5 to
3d66c88
Compare
| } | ||
|
|
||
| { | ||
| auto location = hook::get_pattern<char>("0F B6 C8 83 C8 FF 3B D8 7D 04"); |
There was a problem hiding this comment.
Should the helmet bits in AppearanceDataNode being serialized with 10 bits be documented anywhere?
gottfriedleibniz
approved these changes
Mar 15, 2024
gottfriedleibniz
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
The game has a "soft limit" for the number of available ped props per anchor per model. This patch is intended to fix this limit to allow players to stream more custom ped props.
How is this PR achieving the goal
This PR achieves the goal by patching a set of game functions that clamp 32-bit ped prop indices to 8-bit integers. More detailed explanations are available in the code.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 1604, 2060, 2189, 2372, 2545, 2612, 2699, 2802, 2944, 3095
Platforms: Windows
Checklist
Fixes issues
Addressing a platform suggestion left on the forum:
https://forum.cfx.re/t/request-to-increase-head-prop-limit-in-fivem/5201885