Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): update build instructions and add known issues #2632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Jul 10, 2024

Goal of this PR

More detailed steps for building FXServer, after @FabianTerhorst helped me with an issue. He suggested that I do a PR, so here it is.

How is this PR achieving the goal

  • Specify which .NET version we need to install.
  • Specify that we need to install the Windows 10 SDK.
  • Added steps on how to build FXServer.
  • Added 2 known issues.

This PR applies to the following area(s)

Documentation

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Jul 10, 2024
* Specify which .NET version we need to install.
* Specify that we need to install the Windows 10 SDK.
* Added steps on how to build FXServer.
* Added 2 known issues.
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Jul 10, 2024
@FabianTerhorst
Copy link
Contributor

@jakub-cfx maybe you can find useful information's from here as well related to your build instruction changes.

- `fxd gen -game server`
- `fxd vs -game server`

After running the `fxd vs` command, Visual Studio should open. Set it to `Release` instead of `Debug`, then right-click on the solution and select "Build Solution" or "Rebuild Solution".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to build server in Release and not in Debug?

Copy link
Contributor Author

@spacevx spacevx Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the opposite, was Debug instead of release, good catch

@FabianTerhorst
Copy link
Contributor

FabianTerhorst commented Oct 4, 2024

@ahcenezdh Can you check which of the changes here are still needed after our recent update of the building.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants