tweak(mono-rt2): swap back to using Prop instead of Object #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using Object alongside the regular C# Object leads to annoying cases where you have to disambiguate between if you want to use CitizenFX.Core.Object or System.Object - this goes back to the default that rt1 uses which is to have objects named prop
github-actions
bot
added
the
triage
FabianTerhorst
approved these changes
Aug 20, 2024
FabianTerhorst
added
ready-to-merge
github-actions
bot
added
the
triage
AvarianKnight
added a commit
to AvarianKnight/fivem
that referenced
this pull request
Aug 20, 2024
- as of citizenfx#2731 this is no longer needed
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Using
CitizenFX.Core.Objectalongside the regularSystem.Objectleads to annoying cases where you have to disambiguate between if you want to useCitizenFX.Core.ObjectorSystem.ObjectThis goes back to the default that rt1 uses which is to have
ObjectnamedPropso you don't have to do any disambiguation with CLRHow is this PR achieving the goal
Removes object class for rt2 and just uses the original rt1
PropclassThis PR applies to the following area(s)
FiveM, C#
Successfully tested on
This hasn't been tested.
Game builds: ..
Platforms: Windows
Checklist