feat(rdr): add NETWORK_DOES_ENTITY_EXIST_WITH_NETWORK_ID as a Cfx native #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this native was 'hidden' and didn't have a native declaration since it was removed in RDR, but is generally useful and saves extra native calls - this also duplicates the existing overrides that FiveM has so calling on non-existent net ids/object ids show as a ScRT warning instead of a citizen-core-rdr3
github-actions
bot
added
RedM
martonp96
approved these changes
Oct 16, 2024
martonp96
added
ready-to-merge
|
Tested, working, thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Allow the usage of
NETWORK_DOES_ENTITY_EXIST_WITH_NETWORK_IDwithout needing to directly invoke0x18A47D074708FD68.This also copies the ScRT warnings to provide more useful warnings.
How is this PR achieving the goal
Declared the native as a Cfx native and include scripting core warnings.
This PR applies to the following area(s)
RedM
Successfully tested on
Game builds: 1491
Platforms: Windows
Checklist
Fixes issues