Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(cfx/nui): Hide server reviews *for now* #2913

Closed
wants to merge 3 commits into from
Closed

tweak(cfx/nui): Hide server reviews *for now* #2913

wants to merge 3 commits into from

Conversation

outsider31000
Copy link
Contributor

Goal of this PR

server reviews are mostly a year old we could stop them from showing for now, until there's plans to bring them back.

How is this PR achieving the goal

Hidding reviews since they are a year old mostly.

This PR applies to the following area(s)

RedM/FiveM

Successfully tested on

Game builds: ..

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@outsider31000
tweak(cfx/nui): disable server reviews
33fd9ef 
server reviews are mostly a year old we could stop them for now until there's plans to bring them back
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Nov 6, 2024
@prikolium-cfx prikolium-cfx added status:needs planning Hard issues that take time as there's no 'one' obvious way. status:discussing Request is currently being discussed before being (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Nov 6, 2024
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Dec 4, 2024
@outsider31000
tweak(system_resources/chat): Hide Invalid Commands in Chat
d58ce5f 
users often type invalid commands and this fallback allows to still be posted as message and everyone can see it.

should not be sent if the command doesnt exist usually its a miss type or because theres no chat suggestion
@outsider31000 outsider31000 closed this by deleting the head repository Dec 4, 2024
@outsider31000
Copy link
Contributor Author

outsider31000 commented Dec 4, 2024 •
edited
Loading

ahhhhhh forgot this was here when i deleted the repo xD did not meant to close it.
was a mistake had another pr mixed up lol

#2979 its opened here again sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged status:discussing Request is currently being discussed before being (re)triaged status:needs planning Hard issues that take time as there's no 'one' obvious way.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@outsider31000 @prikolium-cfx