fix(gamestate/server): add array bounds checks and fix native decl. #2923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
This PR addresses two issues: missing bounds checks that allowed reading out-of-bounds memory, and a missing parameter in the native declaration of
GET_VEHICLE_DOOR_STATUS
.How is this PR achieving the goal
GET_VEHICLE_DOOR_STATUS
to include the missingdoorIndex
parameter.doorPositions
inCVehicleGameStateNodeData
.This PR applies to the following area(s)
FiveM, Server
Successfully tested on
Game builds: 3258
Platforms: Windows (Server)
Checklist
Fixes issues
Reported here: https://discord.com/channels/779705925577080842/779739477642838036/1304152704137826304 (Cfx.re Engineering Group)