Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(docs/natives/GetPlayerIdentifierByType): Add link to known identifiers #2948

Merged
merged 1 commit into from
Nov 25, 2024
Merged

tweak(docs/natives/GetPlayerIdentifierByType): Add link to known identifiers #2948

merged 1 commit into from
Nov 25, 2024

Conversation

TheGamerzs
Copy link
Contributor

@TheGamerzs TheGamerzs commented Nov 19, 2024 •
edited
Loading

Goal of this PR

Provide relavent information, regarding identifiers that are returned from this native.

How is this PR achieving the goal

Adds a link to the FiveM Docs listing identifiers that are known.

This PR applies to the following area(s)

Server Native Docs

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Nov 19, 2024
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Nov 19, 2024
@iridium-cfx iridium-cfx self-requested a review November 21, 2024 15:14
iridium-cfx
iridium-cfx approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@iridium-cfx iridium-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@iridium-cfx iridium-cfx added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Nov 21, 2024
@TheGamerzs TheGamerzs mentioned this pull request Nov 21, 2024
Merged
@prikolium-cfx prikolium-cfx merged commit 380377f into citizenfx:master Nov 25, 2024
15 of 21 checks passed
@TheGamerzs TheGamerzs deleted the patch-1 branch February 21, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iridium-cfx iridium-cfx iridium-cfx approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheGamerzs @iridium-cfx @prikolium-cfx