Mumble fixes #2990
Mumble fixes #2990
Conversation
- this fixes audio cutting in/out when playing music that is quiet
…s receiving UDP packets This looks to have been needed for an old issue where FiveM's mumble implementation didn't properly handle resetting the sockets on stream close, which is handled properly now. Mumble hits a "fast path" for reconnecting a client if it reuses the same socket, ad it can just find the client off of the socket and reset the clients crypt state Whenever we recreate the socket we instead hit the "slow path" where the server has to iterate over *every* client connected to mumble and try to see if any of them can decrypt the UDP packet that was sent, which is not optimal.
github-actions
bot
added
RedM
|
Nice to see some improvements, feel correct for most part, and i think having a check on the udp packet like mumble does will indeed improve some connection issue that were not detected before. If you want to try other implementations, there is this one https://github.com/SOZ-Faut-etre-Sub/ZUMBLE that mimic fivem server mumble implementation, (we use it at lot for some years now without any major issue, don't have the ability to compile the fivem client but since we have user on expiremental build we will be able to give you feedback once it's merged) |
- while this *should* never get hit this would prevent us from sending a packet that would get ignored or, in FiveM uMurmurs case disconnected - swaps the voice check to use `m_hasUdp` instead of checking the time
- this should improve how fast the server swaps to/from UDP -> TCP whenever the client is having issues sending UDP
…ng to TCP packets
The server will call `CryptSetup` with no data whenever the client has not responded to a message in a while, this would previously invalidate the players crypt setup and not let them Encrypt/Decrypt data at all This also uses the local crypt state to determine of we should use UDP or TCP This should fix one case of clients having to toggle off/on their voice chat to be able to hear/talk to other players
`HandleClientConnect` expects the `MumbleUser` to hae a valid username and session, but this was only sending the session id, so the audio sink was getting set to an empty user name, resulting in the client never being able to hear anyone until they turned off their voice chat and turned it back on (or got lucky enough that their internet was slow, or initialization was slow and that this wouldn't get hit).
AvarianKnight
force-pushed
the
fix/mumble-fixes
branch
from
7c930dd to
413c248
Compare
Most of my testing was done on my fork of your project, although I did test to make sure the internal uMurmur didn't break because of any of these changes. |
|
Looks all good from what i can tell, most of it has been addressed above. |
prikolium-cfx
added
ready-to-merge
Goal of this PR
How is this PR achieving the goal
Fixes a bunch of different implementation errors, each commit should explain what it does relatively well in the description.
This PR applies to the following area(s)
FiveM, RedM
Successfully tested on
Game builds: 3258
Platforms: Windows
Checklist