Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(server): ignore .github folder in resource scan #3001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jellyton255
Copy link

@jellyton255 jellyton255 commented Dec 14, 2024

Goal of this PR

Like the .git folder, we ignore the .github folder from the resource scan so git repos with a .github folder do not result in a warning during a resource scan.

How is this PR achieving the goal

Adding an additional check to the resource scan loop so that resources with the name ".github" are skipped.

This PR applies to the following area(s)

Server

Successfully tested on

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Dec 14, 2024
@Mathu-lmn
Copy link
Contributor

Why not ignoring all folders starting with a dot ?

@jellyton255
Copy link
Author

Why not ignoring all folders starting with a dot ?

Since resource scan is a critical component, I wouldn't want to change something there unless there was a specific desire to do so, like there is with .github. It may be the case that it's a good idea to ignore all folders with a . in the front, but I personally wouldn't be comfortable with making that change w/o an express desire from Cfx.

@DRAIKDev
Copy link

Also will be great to add .vscode : )

@keeganwut
Copy link

Wouldn't it be better (if possible) to leave this up to a server convar? Being able to define different types of files or folders to ignore? I'm sure this could cause issues but if used correctly potentially not.

@DRAIKDev
Copy link

I think the first server resource checks is done before server convars is settled, also seems a bit unnecessary for the vast majority of servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants