fix(scripting): RPC natives pointer args for player type #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
triage
iridium-cfx
approved these changes
Dec 23, 2024
iridium-cfx
added
ready-to-merge
Oversight from a previous change that didn't account for arguments of type "Player" being charPtr on the server-side.
tens0rfl0w
force-pushed
the
fix/scripting/rpc-player-pointer-args
branch
from
61fe71d to
fa95d3e
Compare
github-actions
bot
added
the
triage
|
Needed a revisit as @AvarianKnight reported that server setters and getters that target players were also broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
ec2ba2e enabled type checking for server natives but didn't account for arguments of type "Player" being
charPtrwithin RPC natives.How is this PR achieving the goal
Manual type fix for args of type
Playerin RPC natives.This PR applies to the following area(s)
FiveM, Server, Natives
Successfully tested on
Game builds: Not applicable
Platforms: Windows, Linux
Checklist
Fixes issues
fixes #3023