Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(gta-five-net): network synchronised scene id hacks #3149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+155 −13
Open

tweak(gta-five-net): network synchronised scene id hacks #3149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions code/components/citizen-server-impl/src/state/ServerGameState.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5747,12 +5747,11 @@ struct CNetworkPtFXEvent

struct CRequestNetworkSyncedSceneEvent
{
uint16_t sceneId;
uint32_t sceneId; // Increased from uint16_t, see "NetworkSynchronisedSceneHacks.cpp"

void Parse(rl::MessageBufferView& buffer)
{
// FIXME: Scene ID length-hack workaround, see `CStartNetworkSyncedSceneEvent`.
sceneId = buffer.Read<uint16_t>(8) | (buffer.Read<uint16_t>(5) << 8);
sceneId = buffer.Read<uint32_t>(32);
}

inline std::string GetName()
Expand Down Expand Up @@ -5839,7 +5838,7 @@ struct CStartNetworkSyncedSceneEvent
};

public:
uint16_t sceneId;
uint32_t sceneId; // Increased from uint16_t, see "NetworkSynchronisedSceneHacks.cpp"
uint32_t startTime;

bool isActive;
Expand Down Expand Up @@ -5873,9 +5872,7 @@ struct CStartNetworkSyncedSceneEvent

void Parse(rl::MessageBufferView& buffer)
{
// FIXME: Synced scene IDs are 13 bits in length, but since it's not an object ID, it's conflicting
// with our length-hack logic... We're working around this issue by reading these 13 bits in two parts.
sceneId = buffer.Read<uint16_t>(8) | (buffer.Read<uint16_t>(5) << 8);
sceneId = buffer.Read<uint32_t>(32);

startTime = buffer.Read<uint32_t>(32);

Expand Down Expand Up @@ -5958,13 +5955,12 @@ struct CStartNetworkSyncedSceneEvent

struct CUpdateNetworkSyncedSceneEvent
{
uint16_t sceneId;
uint32_t sceneId; // Increased from uint16_t, see "NetworkSynchronisedSceneHacks.cpp"
float rate;

void Parse(rl::MessageBufferView& buffer)
{
// FIXME: Scene ID length-hack workaround, see `CStartNetworkSyncedSceneEvent`.
sceneId = buffer.Read<uint16_t>(8) | (buffer.Read<uint16_t>(5) << 8);
sceneId = buffer.Read<uint32_t>(32);

rate = (buffer.Read<uint8_t>(8) / 255.0f) * 2.0f;
}
Expand All @@ -5979,12 +5975,11 @@ struct CUpdateNetworkSyncedSceneEvent

struct CStopNetworkSyncedSceneEvent
{
uint16_t sceneId;
uint32_t sceneId; // Increased from uint16_t, see "NetworkSynchronisedSceneHacks.cpp"

void Parse(rl::MessageBufferView& buffer)
{
// FIXME: Scene ID length-hack workaround, see `CStartNetworkSyncedSceneEvent`.
sceneId = buffer.Read<uint16_t>(8) | (buffer.Read<uint16_t>(5) << 8);
sceneId = buffer.Read<uint32_t>(32);
}

inline std::string GetName()
Expand Down
147 changes: 147 additions & 0 deletions code/components/gta-net-five/src/NetworkSynchronisedSceneHacks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
#include "StdInc.h"

#include "CrossBuildRuntime.h"
#include "Hooking.h"
#include "NetGameEvent.h"

#include <jitasm.h>

template<int Build>
static int GetServerId(const rlGamerInfo<Build>& platformData)
{
return (platformData.peerAddress.localAddr().ip.addr & 0xFFFF) ^ 0xFEED;
}

static int DoGetServerId(CNetGamePlayer* player)
{
if (xbr::IsGameBuildOrGreater<2824>())
{
return GetServerId(*player->GetGamerInfo<2824>());
}

if (xbr::IsGameBuildOrGreater<2372>())
{
return GetServerId(*player->GetGamerInfo<2372>());
}

if (xbr::IsGameBuildOrGreater<2060>())
{
return GetServerId(*player->GetGamerInfo<2060>());
}

return GetServerId(*player->GetGamerInfo<1604>());
}

static constexpr char pattern[] = "\x41\xB8\x0D\x00\x00\x00";
static auto FindPattern(const uintptr_t startAddress)
{
auto address = reinterpret_cast<const uint8_t*>(startAddress);

while (true)
{
assert(*address != 0xE9);

if (memcmp(address, pattern, sizeof(pattern) - 1) == 0)
{
return reinterpret_cast<uintptr_t>(address);
}

++address;
}
}

static uint32_t GetSceneIdOffset(CNetGamePlayer* player)
{
return (DoGetServerId(player) - 1) * 64;
}

static HookFunction hookFunction([]()
{
// StartScene - Serializer
{
//Write
hook::put<uint32_t>(hook::get_pattern("41 B8 ? ? ? ? 48 8B C8 C6 44 24 ? ? E8 ? ? ? ? 48 8B 7C 24", 2), 32);

//Read
hook::put<uint32_t>(hook::get_pattern("41 B8 ? ? ? ? 48 8B C8 48 8B D6", 2), 32);
}

// Request-/StopScene - Serializer
{
const auto cCRequestNetworkSyncedSceneEvent_vtable = hook::get_address<uintptr_t*>(hook::get_pattern<unsigned char>("48 8D 05 ? ? ? ? 89 5E ? 48 8B 5C 24 ? 48 89 06 8A 47", 3));

// Write
uintptr_t target = cCRequestNetworkSyncedSceneEvent_vtable[5];

hook::put<uint32_t>(FindPattern(target) + 2, 32);

// Read
target = cCRequestNetworkSyncedSceneEvent_vtable[6];

hook::put<uint32_t>(FindPattern(target) + 2, 32);
}

// UpdateScene - Serializer
{
const auto cCUpdateNetworkSyncedSceneEvent_vtable = hook::get_address<uintptr_t*>(hook::get_pattern("48 8D 05 ? ? ? ? F3 0F 11 77 ? 0F 28 74 24", 3));

// Write
uintptr_t target = cCUpdateNetworkSyncedSceneEvent_vtable[5];
target = target + 5 + *reinterpret_cast<int32_t*>(target + 1);

hook::put<uint32_t>(FindPattern(target) + 2, 32);

// Read
target = cCUpdateNetworkSyncedSceneEvent_vtable[6];
target = target + 5 + *reinterpret_cast<int32_t*>(target + 1);

hook::put<uint32_t>(FindPattern(target) + 2, 32);
}

// CClonedSynchronizedSceneInfo - Serializer
{
const auto cClonedSynchronizedSceneInfo_vtable = hook::get_address<uintptr_t*>(hook::get_pattern("48 8D 05 ? ? ? ? E9 ? ? ? ? 48 8B 0D ? ? ? ? 45 33 C9 4D 8B C6 BA ? ? ? ? E8 ? ? ? ? 48 85 C0 0F 84 ? ? ? ? 48 8B C8 E8 ? ? ? ? E9 ? ? ? ? 48 8B 0D ? ? ? ? 45 33 C9 4D 8B C6 BA", 3));

int vtableIdx = 24;

if (xbr::IsGameBuildOrGreater<2802>())
{
vtableIdx = 30;
}

hook::put<uint8_t>(cClonedSynchronizedSceneInfo_vtable[vtableIdx] + 0x1F + 3, 32);
}

// CNetworkSynchronizedScenes - Scene Allocator
{
static struct : jitasm::Frontend
{
intptr_t retAddress;

void Init(const intptr_t ret)
{
this->retAddress = ret;
}

void InternalMain() override
{
mov(rcx, rax);
mov(rax, reinterpret_cast<uintptr_t>(&GetSceneIdOffset));
call(rax);
mov(ebp, eax);

mov(rax, retAddress);
jmp(rax);
}
} patchStub;

auto location = hook::get_pattern("0F B6 68 ? C1 E5");

const auto ret = reinterpret_cast<intptr_t>(location) + 7;

patchStub.Init(ret);

hook::nop(location, 7);
hook::jump_rcx(location, patchStub.GetCode());
}
});
Loading