Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to v0.14 #57

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update to v0.14 #57

wants to merge 3 commits into from

Conversation

srghma
Copy link

@srghma srghma commented Jun 18, 2020

What does this pull request do?

here are the changes to next-6 https://github.com/purescript-halogen/purescript-halogen/compare/next-6

How should this be manually tested?

I have this zsh function to link all my local projects

https://github.com/srghma/dotfiles/blob/f0e70f7357a477ece9afa3b78b83185988e3fda2/zsh/link-all-purescript-projects.sh#L1

Other notes

I dont want this pr to be merged now, I have created it just to test that it works with my hydration test project (that is rebased on next-6 as of now)

@thomashoneyman
Copy link
Collaborator

thomashoneyman commented Jun 18, 2020

@srghma Can you please fill out the PR template for future pull requests? It’s there so that the team here can get the gist of the changes before diving into the code. We can review your PRs and get them merged much faster if you help explain the motivation for changes and why they were done a certain way.

In this particular case you’re updating to Halogen 6, so you could just delete the PR template and say that.

I think it’s a bit premature to update given that Halogen 6 doesn’t have a release candidate yet and there may be more changes that require more updates to this library. Is there a particular reason you think the update should happen now?

If so you will also need to update the Spago files so the right version of Halogen is used. You’d need to override the package set to point at Halogen’s next-6 branch.

@srghma
Copy link
Author

srghma commented Jun 18, 2020

@thomashoneyman updates

No, I dont want this pr to be merged now, I have created it just to test that it works with my hydration test project (that is rebased on next-6 as of now)

@thomashoneyman
Copy link
Collaborator

I see. If you don’t want it merged, then can you use a fork of the library to test this instead of keeping a PR open here? Having the PR gives the sense that this is intended to be merged.

@srghma
Copy link
Author

srghma commented Jun 18, 2020

can you use a fork of the library to test this instead of keeping a PR open here?

I thought you will be interested

I would leave it open until next-6 is released (I plan to keep up to date with next-6 and may update this pr later when new changes are introduced)
I dont see a problem with lingering pr's

but yes, we can merge it to new branch next-6 or even close this

@srghma srghma changed the title feat: update to next-6 update to v0.14 Feb 18, 2021
Copy link

@purefunctor purefunctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried migrating the hooks version of halogen-formless to Halogen 6 and had to do some minor edits for the examples to build:

src/Select.purs Outdated Show resolved Hide resolved
hooks v0.5.0 drops HookEquals as its already possible to use type synonyms in this context

Co-authored-by: PureFunctor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants