-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Alias Method Chain With Prepend for SchemaDumper #245
base: master
Are you sure you want to change the base?
Conversation
@rience please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@gurkanindibay Could this be merged and released, please? |
In our application we use this gem and
strong_migrations
that is using prepend method of adding functionality toActiveRecord::SchemaDumper
. Because this one is using alias method chaining - we were hit with stack overflow error when this gem was callingstrong_migrations
and it was then calling initializer which ended up calling this gem again. This PR changes monkey patching approach to use prepend.