Allow configuring sslnegotiation using citus.node_conn_info #7821
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7821 +/- ##
===============================================
Coverage ? 89.63%
===============================================
Files ? 274
Lines ? 59750
Branches ? 7452
===============================================
Hits ? 53555
Misses ? 4063
Partials ? 2132 |
onurctirtir
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
I should've read the PR description more carefully since I was looking for some example PRs in the repo, like the one that you've already noted.
So, after comparing with that PR, this also looks good to me.
naisila
force-pushed
the
naisila/sslnegotiation
branch
from
e37be1b to
2c969df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant PG commit:
postgres/postgres@d39a49c1e
PR similar to #5203