Use asgiref when available instead of thread locals (#176) #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add asgiref as test dependency add tests for asgiref add setting TENANT_USE_ASGIREF, updated tests
…itenant into NewsAmp-asgi-support
* Fixes black issues
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1193 1238 +45
=========================================
+ Hits 1193 1238 +45
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gurkanindibay
changed the title
|
@darwing1210 Could you check this PR which fixes merge conflicts with the new changes |
Looks pretty well, thanks for fixing the merge conflicts |
|
@gurkanindibay any chance you could cut a new release with this in it? Trying to use this project in ASGI and running into issues that I think this change will fix |
|
@paddyobrien Thanks for your interest in the project. We released 4.1.0 version. |
|
@gurkanindibay Thank you so much! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.