Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker to version 11.1.2 #320

Merged

Conversation

gurkanindibay
Copy link
Contributor

@gurkanindibay gurkanindibay commented Sep 30, 2022

pg 15 is not integrated into pipeline I will bake and push it manually

@citusdata citusdata deleted a comment from github-actions bot Sep 30, 2022
@citusdata citusdata deleted a comment from github-actions bot Sep 30, 2022
@citusdata citusdata deleted a comment from github-actions bot Sep 30, 2022
@citusdata citusdata deleted a comment from github-actions bot Sep 30, 2022
@citusdata citusdata deleted a comment from github-actions bot Sep 30, 2022
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove tools submodule
  • What about hyperscale images? Should we update them as well?
  • What about PG12 ? As we dropped support for that PG version already, why don't we delete the Dockerfile for that?

@gurkanindibay
Copy link
Contributor Author

gurkanindibay commented Sep 30, 2022

  • Remove tools submodule
  • What about hyperscale images? Should we update them as well?
  • What about PG12 ? As we dropped support for that PG version already, why don't we delete the Dockerfile for that?

Actually hyperscale files are being used manually. Updating hyperscale files are not standard process for releases
We need to ask it @marcocitus since he can use it for previous versions as well.
But IMO there is no need to update hyperscale files
Fixed other issues

@citusdata citusdata deleted a comment from github-actions bot Sep 30, 2022
@hanefi
Copy link
Member

hanefi commented Sep 30, 2022

I do not see any workflows for PG15. Am I missing something here?

@hanefi
Copy link
Member

hanefi commented Sep 30, 2022

Hadolint output for this run:

{
  "runs": [
    {
      "results": [
        {
          "ruleId": "DL3008",
          "message": {
            "text": "Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`"
          },
          "level": "warning",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "dockerfile",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 17,
                  "endLine": 17
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        },
        {
          "ruleId": "DL3015",
          "message": {
            "text": "Avoid additional packages by specifying `--no-install-recommends`"
          },
          "level": "note",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "dockerfile",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 17,
                  "endLine": 17
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        },
        {
          "ruleId": "SC2086",
          "message": {
            "text": "Double quote to prevent globbing and word splitting."
          },
          "level": "note",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "sh",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 17,
                  "endLine": 17
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        },
        {
          "ruleId": "DL4006",
          "message": {
            "text": "Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check"
          },
          "level": "warning",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "dockerfile",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 17,
                  "endLine": 17
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        },
        {
          "ruleId": "DL3059",
          "message": {
            "text": "Multiple consecutive `RUN` instructions. Consider consolidation."
          },
          "level": "note",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "dockerfile",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 40,
                  "endLine": 40
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        }
      ],
      "tool": {
        "driver": {
          "fullName": "Haskell Dockerfile Linter",
          "shortDescription": {
            "text": "Dockerfile linter, validate inline bash, written in Haskell"
          },
          "name": "Hadolint",
          "version": "v2.9.3-0-g346e419-dirty",
          "downloadUri": "https://github.com/hadolint/hadolint"
        }
      },
      "defaultSourceLanguage": "dockerfile"
    }
  ],
  "version": "2.1.0",
  "$schema": "http://json.schemastore.org/sarif-2.1.0"
}

@gurkanindibay
Copy link
Contributor Author

I do not see any workflows for PG15. Am I missing something here?

​​​​​​​​​​As I write in description, I'm pushing it manually for now I need to change latest into pg 15 and will need to move latest Dockerfile into pg 14, need to change tools code that processing Dockerfiles.
I will all handle them after pg 15 release

@gurkanindibay
Copy link
Contributor Author

gurkanindibay commented Sep 30, 2022

Hadolint output for this run:

{
  "runs": [
    {
      "results": [
        {
          "ruleId": "DL3008",
          "message": {
            "text": "Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`"
          },
          "level": "warning",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "dockerfile",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 17,
                  "endLine": 17
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        },
        {
          "ruleId": "DL3015",
          "message": {
            "text": "Avoid additional packages by specifying `--no-install-recommends`"
          },
          "level": "note",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "dockerfile",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 17,
                  "endLine": 17
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        },
        {
          "ruleId": "SC2086",
          "message": {
            "text": "Double quote to prevent globbing and word splitting."
          },
          "level": "note",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "sh",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 17,
                  "endLine": 17
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        },
        {
          "ruleId": "DL4006",
          "message": {
            "text": "Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check"
          },
          "level": "warning",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "dockerfile",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 17,
                  "endLine": 17
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        },
        {
          "ruleId": "DL3059",
          "message": {
            "text": "Multiple consecutive `RUN` instructions. Consider consolidation."
          },
          "level": "note",
          "locations": [
            {
              "physicalLocation": {
                "region": {
                  "sourceLanguage": "dockerfile",
                  "startColumn": 1,
                  "endColumn": 1,
                  "startLine": 40,
                  "endLine": 40
                },
                "artifactLocation": { "uri": "./Dockerfile" }
              }
            }
          ]
        }
      ],
      "tool": {
        "driver": {
          "fullName": "Haskell Dockerfile Linter",
          "shortDescription": {
            "text": "Dockerfile linter, validate inline bash, written in Haskell"
          },
          "name": "Hadolint",
          "version": "v2.9.3-0-g346e419-dirty",
          "downloadUri": "https://github.com/hadolint/hadolint"
        }
      },
      "defaultSourceLanguage": "dockerfile"
    }
  ],
  "version": "2.1.0",
  "$schema": "http://json.schemastore.org/sarif-2.1.0"
}

@hanefi
I will fix it wth this issue
#321

Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that is left is locally creating and pushing PG15 images.

@gurkanindibay gurkanindibay merged commit 987b702 into master Sep 30, 2022
@gurkanindibay gurkanindibay deleted the release-11.1.2-296e8d66-153b-4a52-976b-669c70efe916 branch September 30, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants