Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker to version 12.1.4 #350

Merged

Conversation

gurkanindibay
Copy link
Contributor

No description provided.

@citusdata citusdata deleted a comment from github-actions bot Jun 6, 2024
@citusdata citusdata deleted a comment from github-actions bot Jun 6, 2024
@citusdata citusdata deleted a comment from github-actions bot Jun 6, 2024
@citusdata citusdata deleted a comment from github-actions bot Jun 6, 2024
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

@@ -1,3 +1,7 @@
### citus-docker v12.1.4.docker (June 06,2024) ###

* Bump Citus version to 12.1.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we stop adding PG version bumps in here?

Should we document it here that we bumped PG versions for 14,15 and 16 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link

github-actions bot commented Jun 6, 2024

Hadolint: ``

{"runs":[{"results":[{"ruleId":"DL3008","message":{"text":"Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`"},"level":"warning","locations":[{"physicalLocation":{"region":{"sourceLanguage":"dockerfile","startColumn":1,"endColumn":1,"startLine":17,"endLine":17},"artifactLocation":{"uri":"./Dockerfile"}}}]},{"ruleId":"DL3015","message":{"text":"Avoid additional packages by specifying `--no-install-recommends`"},"level":"note","locations":[{"physicalLocation":{"region":{"sourceLanguage":"dockerfile","startColumn":1,"endColumn":1,"startLine":17,"endLine":17},"artifactLocation":{"uri":"./Dockerfile"}}}]},{"ruleId":"SC2086","message":{"text":"Double quote to prevent globbing and word splitting."},"level":"note","locations":[{"physicalLocation":{"region":{"sourceLanguage":"sh","startColumn":1,"endColumn":1,"startLine":17,"endLine":17},"artifactLocation":{"uri":"./Dockerfile"}}}]},{"ruleId":"DL4006","message":{"text":"Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check"},"level":"warning","locations":[{"physicalLocation":{"region":{"sourceLanguage":"dockerfile","startColumn":1,"endColumn":1,"startLine":17,"endLine":17},"artifactLocation":{"uri":"./Dockerfile"}}}]},{"ruleId":"DL3059","message":{"text":"Multiple consecutive `RUN` instructions. Consider consolidation."},"level":"note","locations":[{"physicalLocation":{"region":{"sourceLanguage":"dockerfile","startColumn":1,"endColumn":1,"startLine":40,"endLine":40},"artifactLocation":{"uri":"./Dockerfile"}}}]}],"tool":{"driver":{"fullName":"Haskell Dockerfile Linter","shortDescription":{"text":"Dockerfile linter, validate inline bash, written in Haskell"},"name":"Hadolint","version":"v2.9.3-0-g346e419-dirty","downloadUri":"https://github.com/hadolint/hadolint"}},"defaultSourceLanguage":"dockerfile"}],"version":"2.1.0","$schema":"http://json.schemastore.org/sarif-2.1.0"}

Copy link

github-actions bot commented Jun 6, 2024

Hadolint: ``

{"runs":[{"results":[{"ruleId":"DL3008","message":{"text":"Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`"},"level":"warning","locations":[{"physicalLocation":{"region":{"sourceLanguage":"dockerfile","startColumn":1,"endColumn":1,"startLine":17,"endLine":17},"artifactLocation":{"uri":"./Dockerfile"}}}]},{"ruleId":"DL3015","message":{"text":"Avoid additional packages by specifying `--no-install-recommends`"},"level":"note","locations":[{"physicalLocation":{"region":{"sourceLanguage":"dockerfile","startColumn":1,"endColumn":1,"startLine":17,"endLine":17},"artifactLocation":{"uri":"./Dockerfile"}}}]},{"ruleId":"SC2086","message":{"text":"Double quote to prevent globbing and word splitting."},"level":"note","locations":[{"physicalLocation":{"region":{"sourceLanguage":"sh","startColumn":1,"endColumn":1,"startLine":17,"endLine":17},"artifactLocation":{"uri":"./Dockerfile"}}}]},{"ruleId":"DL4006","message":{"text":"Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check"},"level":"warning","locations":[{"physicalLocation":{"region":{"sourceLanguage":"dockerfile","startColumn":1,"endColumn":1,"startLine":17,"endLine":17},"artifactLocation":{"uri":"./Dockerfile"}}}]},{"ruleId":"DL3059","message":{"text":"Multiple consecutive `RUN` instructions. Consider consolidation."},"level":"note","locations":[{"physicalLocation":{"region":{"sourceLanguage":"dockerfile","startColumn":1,"endColumn":1,"startLine":40,"endLine":40},"artifactLocation":{"uri":"./Dockerfile"}}}]}],"tool":{"driver":{"fullName":"Haskell Dockerfile Linter","shortDescription":{"text":"Dockerfile linter, validate inline bash, written in Haskell"},"name":"Hadolint","version":"v2.9.3-0-g346e419-dirty","downloadUri":"https://github.com/hadolint/hadolint"}},"defaultSourceLanguage":"dockerfile"}],"version":"2.1.0","$schema":"http://json.schemastore.org/sarif-2.1.0"}

@gurkanindibay gurkanindibay merged commit 0016767 into master Jun 6, 2024
13 checks passed
@gurkanindibay gurkanindibay deleted the release-12.1.4-5d14070e-fc86-4ca4-9546-ac6f8c9a0b13 branch June 6, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants